-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(remote-build): parse --launchpad-timeout
argument
#4426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Callahan Kovacs <[email protected]>
4 tasks
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #4426 +/- ##
==========================================
+ Coverage 89.18% 89.20% +0.02%
==========================================
Files 322 322
Lines 21659 21663 +4
==========================================
+ Hits 19316 19324 +8
+ Misses 2343 2339 -4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Store spread test failure is unrelated (#4411) |
syu-w
approved these changes
Oct 26, 2023
lengau
reviewed
Oct 27, 2023
lengau
reviewed
Oct 27, 2023
Signed-off-by: Callahan Kovacs <[email protected]>
mr-cal
force-pushed
the
remote-build-timeout-main
branch
from
October 27, 2023 18:28
0c29337
to
3484a1e
Compare
lengau
approved these changes
Oct 27, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make lint
?pytest tests/unit
?Two changes:
--launchpad-timeout
was not parsed and could not be used by the fallback remote builder.--launchpad-timeout
in new remote builderNote - I made 2 PRs (this one and #4427) because the remote build code is very different between
main
and thehotfix/7.5
branches (main
has the new remote builder code,hotfix/7.5
does not).Fixes #4397
(CRAFT-2094)