Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: download snap to tests dir #4380

Merged
merged 2 commits into from
Sep 28, 2023
Merged

ci: download snap to tests dir #4380

merged 2 commits into from
Sep 28, 2023

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Sep 26, 2023

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

The scheduled spread tests were not downloading the snap to the tests/ directory.

I triggered a run and it is working now. See logs here: https://github.com/snapcore/snapcraft/actions/runs/6313456368

Signed-off-by: Callahan Kovacs <[email protected]>
Copy link
Contributor

@cmatsuoka cmatsuoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2023

Codecov Report

Merging #4380 (98242a1) into main (0544bd3) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main    #4380      +/-   ##
==========================================
- Coverage   89.12%   89.11%   -0.01%     
==========================================
  Files         318      318              
  Lines       21174    21174              
==========================================
- Hits        18871    18870       -1     
- Misses       2303     2304       +1     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mr-cal mr-cal merged commit 0de1f0e into main Sep 28, 2023
11 checks passed
@mr-cal mr-cal deleted the spread-scheduled-fix branch September 28, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants