refactor(parts): separate yaml parsing from base errors #4342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Callahan Kovacs <[email protected]>
mr-cal
force-pushed
the
yaml-refactor-2
branch
from
8d0218e
to
6ce7ad8
Compare
syu-w
approved these changes
Aug 31, 2023
Signed-off-by: Callahan Kovacs <[email protected]>
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more. @@ Coverage Diff @@
## main #4342 +/- ##
==========================================
+ Coverage 89.10% 89.12% +0.01%
==========================================
Files 299 300 +1
Lines 20594 20637 +43
==========================================
+ Hits 18350 18392 +42
- Misses 2244 2245 +1
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cmatsuoka
approved these changes
Aug 31, 2023
jardon
pushed a commit
to jardon/snapcraft
that referenced
this pull request
Sep 6, 2023
Signed-off-by: Callahan Kovacs <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make lint?pytest tests/unit?No functional changes.
Another precursory refactor for #4318 in which I need to load a
snapcraft.yamland check the base without raising an error.(CRAFT-1972)