bases: improve errors for ESM bases #4274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiusens
force-pushed
the
work/CRAFT-1850-better-error-for-core18
branch
from
1bc9e1f
to
3150ce2
Compare
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #4274 +/- ##
==========================================
- Coverage 88.98% 88.97% -0.01%
==========================================
Files 296 295 -1
Lines 20194 20167 -27
==========================================
- Hits 17970 17944 -26
+ Misses 2224 2223 -1
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sergiusens
force-pushed
the
work/CRAFT-1850-better-error-for-core18
branch
from
3150ce2
to
58a18e2
Compare
Bases that were once supported and no longer supported in the current version provide a reference to the version/channel of Snapcraft where they once were. Signed-off-by: Sergio Schvezov <[email protected]>
sergiusens
force-pushed
the
work/CRAFT-1850-better-error-for-core18
branch
from
58a18e2
to
693429f
Compare
tigarmo
reviewed
Jul 13, 2023
Co-authored-by: Tiago Nobrega <[email protected]>
tigarmo
approved these changes
Jul 13, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bases that were once supported and no longer supported in the current version provide a reference to the version/channel of Snapcraft where they once were.
make lint?pytest tests/unit?Fixes #4246