Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added comments to indicate where the desktop-launch script source is #4250

Merged
merged 2 commits into from
Jul 6, 2023

Conversation

kenvandine
Copy link
Contributor

Added comments to indicate where the desktop-launch script source lives for the gnome extension with core22 and later

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

from for the gnome extension with core22 and later
Copy link
Contributor

@seb128 seb128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that seems an improvement. We should also try to mention during reviews to contributors who submit a fix for the launchpad in snapcraft (or can we have an issue template specific to a part of the project?)

@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2023

Codecov Report

Merging #4250 (0810921) into main (fc985d4) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main    #4250      +/-   ##
==========================================
+ Coverage   88.96%   88.98%   +0.01%     
==========================================
  Files         295      296       +1     
  Lines       20151    20192      +41     
==========================================
+ Hits        17928    17968      +40     
- Misses       2223     2224       +1     

see 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mr-cal mr-cal merged commit 36cc6f7 into canonical:main Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants