Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spread: improve resilience of lxd-type-base test #4239

Merged
merged 3 commits into from
Jun 30, 2023

Conversation

lengau
Copy link
Contributor

@lengau lengau commented Jun 28, 2023

This test often times out on lxc stop on Google runners.

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

#4236

@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2023

Codecov Report

Merging #4239 (d5edb7e) into main (f5b2f2e) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main    #4239   +/-   ##
=======================================
  Coverage   88.96%   88.96%           
=======================================
  Files         295      295           
  Lines       20151    20151           
=======================================
  Hits        17928    17928           
  Misses       2223     2223           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sergiusens
Copy link
Collaborator

can this go to hotfix/7.5 first?

@sergiusens
Copy link
Collaborator

nevermind, everything seems more funtional today

@lengau lengau marked this pull request as ready for review June 30, 2023 22:04
@lengau lengau merged commit ab2c135 into canonical:main Jun 30, 2023
@lengau lengau deleted the lxd-type-base branch June 30, 2023 22:05
@sergiusens
Copy link
Collaborator

remember, no merge commits in main

@lengau
Copy link
Contributor Author

lengau commented Jul 3, 2023

@sergiusens oops, sorry - meant to squash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants