Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: do not check coverage of tests dir #4222

Merged
merged 2 commits into from
Jun 20, 2023
Merged

ci: do not check coverage of tests dir #4222

merged 2 commits into from
Jun 20, 2023

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Jun 19, 2023

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

pytest was checking the coverage of the tests dir.

For example:
image

@codecov-commenter
Copy link

codecov-commenter commented Jun 19, 2023

Codecov Report

Merging #4222 (79bee0c) into main (ba7d74c) will decrease coverage by 4.93%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main    #4222      +/-   ##
==========================================
- Coverage   93.88%   88.95%   -4.93%     
==========================================
  Files         569      296     -273     
  Lines       43730    20157   -23573     
==========================================
- Hits        41054    17931   -23123     
+ Misses       2676     2226     -450     

see 291 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mr-cal mr-cal requested review from lengau and tigarmo June 20, 2023 00:30
@mr-cal mr-cal merged commit 0ad49f3 into main Jun 20, 2023
@mr-cal mr-cal deleted the pytest-coverage branch June 20, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants