Hotfix/7.4 merge #4213
Merged
Hotfix/7.4 merge #4213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In remote-build a proxy is used and passed as env var. When calling rosdep init as root those env var were not forwarded. This was causing core20 and core22 ROS snap to be unbuildable on remote-build rosdep doesn't support proxy: ros-infrastructure/rosdep#271
Signed-off-by: Claudio Matsuoka <[email protected]>
`ubnutu-core-initramfs` tool changed where `snap-boostrap` is fetched from. It assumes `snap-bootstrap` from passed `--root` to be used. Unpack the downloaded snapd debian package to the same directory where "ubnutu-core-initramfs" debian package is unpacked. This directory is already passed to the `ubnutu-core-initramfs` tool as `--root` Signed-off-by: Ondrej Kubik <[email protected]>
Required by "debian/rules clean" call Signed-off-by: Ondrej Kubik <[email protected]>
Craft Parts 1.19.6 reverts subdir changes in pull and build steps. Signed-off-by: Claudio Matsuoka <[email protected]>
Signed-off-by: Callahan Kovacs <[email protected]>
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #4213 +/- ##
=======================================
Coverage 88.98% 88.98%
=======================================
Files 296 296
Lines 20192 20192
=======================================
Hits 17968 17968
Misses 2224 2224
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
For the failing linter spread test: There was a spread test fix done on @cmatsuoka reverted it on |
|
Today, that same spread test started breaking again on Edit: I fixed the test in |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make lint?pytest tests/unit?