Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(catkin): rosbash is an unofficial ros package from Debian #4206

Merged

Conversation

Guillaumebeuzeboc
Copy link
Contributor

@Guillaumebeuzeboc Guillaumebeuzeboc commented Jun 8, 2023

rosbash is an unofficial ROS package from Debian robotics team pulled in Ubuntu universe.

ros-noetic-rosbash is the official from ROS

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

…s team

rosbash is an unofficial ros package from Debian robotics team.
ros-noetic-rosbash is the official from ROS
@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2023

Codecov Report

Merging #4206 (f009ab7) into main (13071d7) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main    #4206   +/-   ##
=======================================
  Coverage   93.90%   93.90%           
=======================================
  Files         569      569           
  Lines       43746    43746           
=======================================
  Hits        41078    41078           
  Misses       2668     2668           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Guillaumebeuzeboc Guillaumebeuzeboc marked this pull request as ready for review June 8, 2023 09:13
@cmatsuoka
Copy link
Contributor

It seems that we also need to revert d48db22

@mr-cal
Copy link
Collaborator

mr-cal commented Jun 15, 2023

Reverted in #4212

@cmatsuoka cmatsuoka merged commit ebf02e2 into canonical:main Jun 15, 2023
@Guillaumebeuzeboc Guillaumebeuzeboc deleted the fix/remove_deprecated_ros_pkg branch June 16, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants