Remove trailing slashes from tools/staging_env.sh #4201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The motivating case was STORE_UPLOAD_URL. With a trailing slash,
I fail to upload to the staging Store:
snapcraft upload jhartley-two_1.4_amd64.snap
craft-store error: Issue encountered while processing
your request: [405] Method Not Allowed.
I see roadmr already submitted [an old unmerged
PR](canonical#3876) to fix this
particular slash, and in the comments @sergiusens asked if he could
[remove the trailing slashes from all envvars](canonical#3876 (comment)),
so this PR does that.
|
The CLA check could be failing if you signed the CLA with your |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #4201 +/- ##
=======================================
Coverage 93.90% 93.90%
=======================================
Files 569 569
Lines 43746 43746
=======================================
Hits 41078 41078
Misses 2668 2668 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mr-cal
approved these changes
Jun 6, 2023
|
Thank you! |
4 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivating case was STORE_UPLOAD_URL. With a trailing slash,
I fail to upload to the staging Store:
I see roadmr already submitted an old unmerged PR to fix this
particular slash, and in the comments @sergiusens asked if he could
remove the all trailing slashes from envvars, so this PR does that.
make lint?pytest tests/unit?I don't have a working snapcraft dev env. Taking a look at what
is needed, will update this when I succeed...