elf_utils: add missing triplet for i386 #4188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiusens
approved these changes
Jun 1, 2023
|
Looks good in principle, there are other affected tests though |
When cross compiling a snap to i386, snap yaml generation fails with `RuntimeError: Arch triplet not defined for arch 'i686'` ``` architectures: - build-on: amd64 build-for: i386 ```
valentindavid
force-pushed
the
valentindavid/i686-triplet
branch
from
916b996
to
5794639
Compare
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #4188 +/- ##
=======================================
Coverage 93.90% 93.90%
=======================================
Files 569 569
Lines 43746 43746
=======================================
Hits 41078 41078
Misses 2668 2668
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I had a error. Now there is one spread test that is failing but I have no idea why it fails:
|
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When cross compiling a snap to i386, snap yaml generation fails with
RuntimeError: Arch triplet not defined for arch 'i686'make lint?pytest tests/unit?