Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For consistency, rename new kernel plugin file to "kernel_plugin.py" #4164

Merged
merged 5 commits into from
Jun 6, 2023

Conversation

rpjday
Copy link
Contributor

@rpjday rpjday commented May 20, 2023

The legacy plugin files were left as is to minimize churn.

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

The legacy plugin files were left as is to minimize churn.

Signed-off-by: Robert P. J. Day <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2023

Codecov Report

Merging #4164 (439e58a) into main (f0f4373) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main    #4164   +/-   ##
=======================================
  Coverage   93.90%   93.90%           
=======================================
  Files         569      569           
  Lines       43744    43746    +2     
=======================================
+ Hits        41076    41078    +2     
  Misses       2668     2668           
Impacted Files Coverage Δ
snapcraft/elf/elf_utils.py 95.38% <ø> (ø)
snapcraft/parts/plugins/kernel_plugin.py 100.00% <ø> (ø)
tests/unit/elf/test_elf_utils.py 100.00% <ø> (ø)
snapcraft/parts/plugins/__init__.py 100.00% <100.00%> (ø)
snapcraft/parts/plugins/register.py 100.00% <100.00%> (ø)
snapcraft/providers.py 97.75% <100.00%> (+0.02%) ⬆️
tests/unit/parts/plugins/test_kernel.py 98.57% <100.00%> (ø)
tests/unit/parts/test_lifecycle.py 100.00% <100.00%> (ø)
tests/unit/test_providers.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants