-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add V2 Ruby plugin #3511
base: main
Are you sure you want to change the base?
add V2 Ruby plugin #3511
Conversation
Thanks for collaborating on this. Looks good, I have a couple of suggestions to make (aside from testing) that I will propose as soon as I have some time available |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good, have a few suggestions - thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How complicated would it be to have ruby as a content snap and deliver the entire hookup through an extension?
And apologies for the late response, I had an intense event and a full disconnect afterwards. |
I'm sorry, but I don't understand the question. Content snap? Hookup? What I'm already doing in a project is using this plugin in a part of its own without a |
Co-authored-by: Sergio Schvezov <[email protected]>
Co-authored-by: Sergio Schvezov <[email protected]>
Co-authored-by: Sergio Schvezov <[email protected]>
Please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @paddor,
Apologies for the long delay in reviews. I'm happy to help you drive this and canonical/craft-parts#341 to completion.
I think next step is an integration test that builds a "hello world" Ruby app. You would need to add the test here and the source files for the app in a directory here. Testing this requires installing spread and running it locally with Multipass.
Alternatively, you could add the "hello world" integration test in craft-parts here (which doesn't use spread) and I can help translate it to a spread test in this PR.
Referring to https://forum.snapcraft.io/t/local-v2-plugins/23903