Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugins: Pin pip to supported versions #3429

Merged
merged 1 commit into from
Jan 26, 2021
Merged

plugins: Pin pip to supported versions #3429

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion snapcraft/plugins/_python/_pip.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,12 @@ def _ensure_pip_installed(self):
self.__python_home = os.path.join(os.path.sep, "usr")

# Using the host's pip, install our own pip
self.download({"pip"})
# pip >=21 no longer support python3.5 or python 2 and if
# used will result in a broken install with pip unable to
# install packages.
self.download(
{'pip; python_version >= "3.6"', 'pip<21; python_version < "3.6"'}
)
self.install({"pip"}, ignore_installed=True)
finally:
# Now that we have our own pip, reset the python home
Expand Down