Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extra logging #3836

Merged
merged 3 commits into from
Jan 7, 2022
Merged

Extra logging #3836

merged 3 commits into from
Jan 7, 2022

Conversation

jkfran
Copy link
Contributor

@jkfran jkfran commented Jan 7, 2022 •
edited
Loading

Done

How to QA

  • Check the dotrun snap output
  • The PID should be present on this kind of logs:
2022-01-07 12:55:36.230Z DEBUG gunicorn.error "GET /store/featured-snaps/games" service=snapcraft.io pid=1339778
  • We should have START logs, like:
2022-01-07 12:55:36.236Z INFO talisker.wsgi "START view=store.featured_snaps_in_category path=/store/featured-snaps/games" service=snapcraft.io pid=1339778 request_id=1e1f222a-c589-42ee-8019-8368dfbb429e

@webteam-app
Copy link

Demo starting at https://snapcraft-io-3836.demos.haus

@jkfran jkfran mentioned this pull request Jan 7, 2022
Merged
nottrobin
nottrobin reviewed Jan 7, 2022
View reviewed changes
webapp/app.py Outdated Show resolved Hide resolved
@jkfran jkfran force-pushed the extra-logging branch 2 times, most recently from 5609a93 to 2e7d6b4 Compare January 7, 2022 14:28
@jkfran jkfran removed the Don't merge label Jan 7, 2022
nottrobin
nottrobin approved these changes Jan 7, 2022
View reviewed changes
Copy link
Contributor

@nottrobin nottrobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nottrobin nottrobin merged commit 5f86957 into canonical:main Jan 7, 2022
@jkfran jkfran mentioned this pull request Jan 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nottrobin nottrobin nottrobin approved these changes

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jkfran @webteam-app @nottrobin