Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface tests #31

Merged
merged 12 commits into from
Jan 3, 2024
Merged

Interface tests #31

merged 12 commits into from
Jan 3, 2024

Conversation

arturo-seijas
Copy link
Collaborator

@arturo-seijas arturo-seijas commented Jan 2, 2024

Applicable spec: N/A

Overview

Interface tests corresponding to canonical/charm-relation-interfaces#126

Rationale

N/A

Juju Events Changes

N/A

Module Changes

N/A

Library Changes

N/A

Checklist

@arturo-seijas arturo-seijas marked this pull request as ready for review January 2, 2024 13:32
@arturo-seijas arturo-seijas requested a review from a team as a code owner January 2, 2024 13:32
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 54 files.

Valid Invalid Ignored Fixed
0 18 36 0
Click to see the invalid file list
  • charmcraft.yaml
  • config.yaml
  • generate-src-docs.sh
  • metadata.yaml
  • src/charm.py
  • src/charm_state.py
  • tests/conftest.py
  • tests/integration/init.py
  • tests/integration/any_charm.py
  • tests/integration/conftest.py
  • tests/integration/test_charm.py
  • tests/interface/init.py
  • tests/interface/conftest.py
  • tests/interface/test_smtp.py
  • tests/unit/init.py
  • tests/unit/test_charm.py
  • tests/unit/test_charm_state.py
  • tests/unit/test_library_smtp.py

tests/interface/__init__.py Outdated Show resolved Hide resolved
tests/interface/conftest.py Outdated Show resolved Hide resolved
tests/interface/test_smtp.py Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Jan 3, 2024

Test coverage for c4189ac

Name                                    Stmts   Miss Branch BrPart  Cover   Missing
-----------------------------------------------------------------------------------
lib/charms/smtp_integrator/v0/smtp.py     116      2     20      2    97%   319, 321
src/charm.py                               82      5     26      1    94%   90-92, 101-102
src/charm_state.py                         44      0      6      0   100%
-----------------------------------------------------------------------------------
TOTAL                                     242      7     52      3    97%

Static code analysis report

Run started:2024-01-03 09:20:00.676052

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 889
  Total lines skipped (#nosec): 3
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

Copy link

@yanksyoon yanksyoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, out of curiosity, how does this interface testing work?

@arturo-seijas
Copy link
Collaborator Author

LGTM, out of curiosity, how does this interface testing work?

It relies on the interface tester to run the tests as defined here

@arturo-seijas arturo-seijas merged commit 2fb8678 into main Jan 3, 2024
26 of 28 checks passed
@arturo-seijas arturo-seijas deleted the interface-tests branch January 3, 2024 10:22
@arturo-seijas arturo-seijas mentioned this pull request Jan 3, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants