Skip to content
This repository has been archived by the owner on Dec 18, 2024. It is now read-only.

feat: Store authentication keys in a separate database #39

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

gatici
Copy link
Contributor

@gatici gatici commented Feb 20, 2024

Description

The upstream PR requires changes in the charm to use the second database and it's merged.
This PR has dependency to canonical/sdcore-webui-rock#17 which updates webconsole image.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • [] I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have bumped the version of the library

@gatici gatici requested a review from a team as a code owner February 20, 2024 11:24
@gatici gatici force-pushed the TELCO-880-Use-separate-db-for-authentication-keys branch from 8567b41 to 0707b24 Compare February 20, 2024 12:10
@gatici gatici changed the title Store authentication keys in a separate database feat: Store authentication keys in a separate database Feb 20, 2024
@ghislainbourgeois
Copy link

I assume this will require a separate PR to update the rock once the upstream PR is merged, right?

src/charm.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
@gatici
Copy link
Contributor Author

gatici commented Feb 23, 2024

I assume this will require a separate PR to update the rock once the upstream PR is merged, right?

I assume this will require a separate PR to update the rock once the upstream PR is merged, right?

I assume this will require a separate PR to update the rock once the upstream PR is merged, right?

Hello @ghislainbourgeois That's true. After merging Upstream PR, I will create a separate PR to update Webui Rock.

@gatici gatici force-pushed the TELCO-880-Use-separate-db-for-authentication-keys branch from 0707b24 to 8a6deeb Compare February 23, 2024 11:13
@gatici gatici force-pushed the TELCO-880-Use-separate-db-for-authentication-keys branch from 8a6deeb to deff8dd Compare February 23, 2024 11:16
@gatici gatici force-pushed the TELCO-880-Use-separate-db-for-authentication-keys branch from deff8dd to f043a3f Compare February 23, 2024 11:24
@gatici gatici merged commit 9a0682b into main Feb 26, 2024
9 checks passed
@gatici gatici deleted the TELCO-880-Use-separate-db-for-authentication-keys branch February 26, 2024 14:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants