Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use integrate() instead of add_relation() #23

Merged
merged 2 commits into from
Oct 20, 2023
Merged

Conversation

DanielArndt
Copy link
Member

add_relation() is deprecated and will be remove in the future. This removes the warning log.

Also, assert assumptions instead of ignoring the type checker.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have bumped the version of the library

`add_relation()` is deprecated and will be remove in the future. This removes the warning log.

Also, assert assumptions instead of ignoring the type checker.
@DanielArndt DanielArndt requested a review from a team as a code owner October 19, 2023 11:38
@DanielArndt DanielArndt merged commit 1c7ea1d into main Oct 20, 2023
8 checks passed
@DanielArndt DanielArndt deleted the integrate-not-relate branch October 20, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants