Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stored state from the redis library #83

Merged
merged 2 commits into from
May 23, 2024
Merged

Remove stored state from the redis library #83

merged 2 commits into from
May 23, 2024

Conversation

arturo-seijas
Copy link
Contributor

Issue

#74

Solution

Removes stored state, breaking compatibility

@reneradoi
Copy link
Contributor

The update to the lib version causes the charmcraft pack command to fail with:

Library 'lib/charms/redis_k8s/v0/redis.py' metadata field LIBAPI is different from the version in the path.                                             
Failed to build charm for bases index '0'.

both locally and in CI.

@reneradoi reneradoi self-requested a review May 22, 2024 07:21
Copy link
Contributor

@Mehdi-Bendriss Mehdi-Bendriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that we are breaking backward compatibility by keeping the major version of the lib as is, but we are purposefully doing so as we consider the use of the storedstate object in the relation to be a bug.

@Mehdi-Bendriss Mehdi-Bendriss merged commit 7edec05 into canonical:main May 23, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants