chore(lib): Updated url with the leader host

[alithethird]

Issue

Since DPE-5200 add leader info to relation data PR we need to update a lot of our(IS DevOps) charms to use the leader-host. We also use the .url property but since it uses the unit ip we have to construct it in the charm.

Solution

Constructing the .url property in the library instead of changing multiple number of charms.

[reneradoi]

Hello @alithethird , I tried to look into the issue with the failed integration test. It is failing in the build-step, probably because of the change to the lib. Unfortunately I cannot really debug that without cloning your private repo. Could you please create a branch on this repo here, and push your changes to this new branch? We can also have a session together if that would help you, just let me know.

[alithethird]

Hi @reneradoi ! Thank you! I can not create a branch because I do not have write access. My fork should be private but just in case I added you as a collaborator to the fork.

[reneradoi]

Hey @alithethird, in general we'd be fine with adjusting this, as long as the interface stays the same. But after looking at the failing test, I don't think that this is flaky as you mentioned earlier. I have run the integration tests against the main branch on multiple tries, and there was no failure.

The error from the CI pipeline is here. I suggest you check this and adjust your code accordingly.

[reneradoi]

@alithethird After debugging with a local deployment, I've found the cause of the failing tests and fixed it by updating the pylibjuju to a newer version. Tests are now stable again. Furthermore I've adjusted the logic for the lib changes a little to make them more robust. Please have another look if this is fine for you.

[Mehdi-Bendriss]

Thanks! Left a minor comment

[alithethird]

Looks great! Thanks a lot for your time.