feat(CustomSelect): Upstream CustomSelect component [WD-17720] #1168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demo
Jenkins 
demos.haus 
mas-who
changed the title
mas-who
force-pushed
the
upstream-custom-select
branch
3 times, most recently
from
6cb56e0 to
8b62796
Compare
Signed-off-by: Mason Hu <[email protected]>
mas-who
force-pushed
the
upstream-custom-select
branch
from
8b62796 to
28fa618
Compare
src/components/CustomSelect/CustomSelectDropdown/CustomSelectDropdown.tsx
Outdated
Show resolved
Hide resolved
src/components/CustomSelect/CustomSelectDropdown/CustomSelectDropdown.tsx
Outdated
Show resolved
Hide resolved
fasih-mehmood
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Great work @mas-who, left a couple of comments. This looks and works great, thank you!
fasih-mehmood
added
Review: Code +1
Review: QA +1
and removed
Review: Code needed
Review: QA needed
labels
Signed-off-by: Mason Hu <[email protected]>
Signed-off-by: Mason Hu <[email protected]>
Signed-off-by: Mason Hu <[email protected]>
mas-who
force-pushed
the
upstream-custom-select
branch
from
4b0a3e4 to
a08f5a0
Compare
fasih-mehmood
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
CustomSelectcomponent from lxd-uiQA
Storybook
To see rendered examples of all react-components, run:
QA in your project
from
react-componentsrun:Install the resulting tarball in your project with:
QA steps