fix: make multiselect dropdown spacing consistent #1165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demo
Jenkins 
demos.haus 
jmuzina
changed the title
jmuzina
force-pushed
the
even-multiselect-spacing
branch
from
6e1c71d to
f06c0bf
Compare
|
Design +1 by @lyubomir-popov here |
ethanashaw
requested review from
yurii-vasyliev
and removed request for
ethanashaw
|
I transferred review to Yurii, he was the one that noticed it and asked me to fix it. |
advl
approved these changes
Dec 13, 2024
|
🎉 This PR is included in version 1.7.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
QA
Review multiselect dropdown and ensure that the top and bottom spacing is correct.
Storybook
To see rendered examples of all react-components, run:
QA in your project
from
react-componentsrun:Install the resulting tarball in your project with:
Fixes
Fixes: #1164