Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove invalid syntax for style imports #1021

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

mas-who
Copy link
Contributor

@mas-who mas-who commented Jan 19, 2024

Done

  • fix issue with style imports with the ~ prefix not working with projects built with vite.

QA

Storybook

To see rendered examples of all react-components, run:

yarn start

QA in your project

from react-components run:

yarn build
npm pack

Install the resulting tarball in your project with:

yarn add <path-to-tarball>

QA steps

  • Check that styling for the table pagination component still looks okay in storybook

@webteam-app
Copy link

Demo starting at https://react-components-1021.demos.haus

Copy link
Member

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to fix the issue. Styling still works in storybook.

It would be good if the CSS followed Vanilla naming convention better, but it's not scope of this PR, so lets leave it and fix later.

@mas-who mas-who merged commit ffd122e into canonical:main Jan 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants