Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update helm charts to handle rockcraft and a different storage.path #2

Conversation

addyess
Copy link

@addyess addyess commented Jan 31, 2024

Parameterize the storage path location, and if the image is the canonical rockcraft based image, launch with pebble arguments

Installation of the rockcraft image:

sudo k8s helm install -n kube-system \
    --set controller.image.repository=ghcr.io/canonical/rawfile-localpv \
    --set node.image.repository=ghcr.io/canonical/rawfile-localpv \
    --set node.storage.path=/var/snap/k8s/common/local-storage \
    --set serviceMonitor.enabled=false \
    --set node.image.tag=0.8.0-ck1 \
    --set controller.image.tag=0.8.0-ck1 \
    --set controller.csiDriverArgs='{--args,rawfile,csi-driver,--disable-metrics}' \
    rawfile-csi ./deploy/charts/rawfile-csi/

Copy link

@neoaggelos neoaggelos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first pass of comments

@addyess addyess force-pushed the KU-275-update-rawfile-localpv-chart-to-specify-a-custom-host-directory branch from b53a23e to 9eb71c3 Compare February 1, 2024 17:49
@addyess addyess force-pushed the KU-275-update-rawfile-localpv-chart-to-specify-a-custom-host-directory branch from 9eb71c3 to 9fe4698 Compare February 1, 2024 17:49
Copy link

@neoaggelos neoaggelos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@addyess addyess merged commit e3ea721 into rockcraft Feb 2, 2024
3 checks passed
@addyess addyess deleted the KU-275-update-rawfile-localpv-chart-to-specify-a-custom-host-directory branch February 2, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants