Fallback to trying to create bucket without LocationConstraint #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #690 +/- ##
==========================================
+ Coverage 71.82% 71.84% +0.02%
==========================================
Files 13 13
Lines 3219 3229 +10
Branches 477 478 +1
==========================================
+ Hits 2312 2320 +8
- Misses 791 793 +2
Partials 116 116 ☔ View full report in Codecov by Sentry. |
hloeung
force-pushed
the
create-bucket-no-region
branch
from
b3ff9f4 to
67512fc
Compare
hloeung
force-pushed
the
create-bucket-no-region
branch
3 times, most recently
from
9dbdd02 to
58064df
Compare
taurus-forever
pushed a commit
to canonical/data-platform-workflows
that referenced
this pull request
Dec 4, 2024
…ev (#251) This fixes an issue where it fails due to trying to install an older version which no longer exists. See https://github.com/canonical/postgresql-operator/actions/runs/12155829148/job/33898208024 for canonical/postgresql-operator#690  ``` Reading package lists... Building dependency tree... Reading state information... Suggested packages: postgresql-doc-14 The following NEW packages will be installed: libpq-dev 0 upgraded, 1 newly installed, 0 to remove and 26 not upgraded. Need to get 148 kB of archives. After this operation, 589 kB of additional disk space will be used. Ign:1 http://ports.ubuntu.com/ubuntu-ports jammy-updates/main arm64 libpq-dev arm64 14.13-0ubuntu0.22.04.1 Err:1 http://ports.ubuntu.com/ubuntu-ports jammy-updates/main arm64 libpq-dev arm64 14.13-0ubuntu0.22.04.1 404 Not Found [IP: 185.125.190.39 80] E: Failed to fetch http://ports.ubuntu.com/ubuntu-ports/pool/main/p/postgresql-14/libpq-dev_14.13-0ubuntu0.22.04.1_arm64.deb 404 Not Found [IP: 185.125.190.39 80] E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing? Error: Process completed with exit code 100. ``` Where it tries `14.13-0ubuntu0.22.04.1`, but per https://launchpad.net/ubuntu/+source/postgresql-14, it's at `14.15-0ubuntu0.22.04.1`. One other solution is to ensure we always use the daily images.
hloeung
force-pushed
the
create-bucket-no-region
branch
3 times, most recently
from
258b3d3 to
924af8a
Compare
|
Looks like I'll need to wait for #692 as well |
hloeung
force-pushed
the
create-bucket-no-region
branch
from
924af8a to
5703059
Compare
dragomirp
requested review from
a team,
taurus-forever,
dragomirp,
marceloneppel and
lucasgameiroborges
and removed request for
a team
dragomirp
reviewed
Dec 4, 2024
hloeung
force-pushed
the
create-bucket-no-region
branch
3 times, most recently
from
09b900e to
8b48898
Compare
hloeung
force-pushed
the
create-bucket-no-region
branch
from
8b48898 to
c13e470
Compare
|
Any updates on this? As it is right now, even with manually creating the bucket, I can't get backups to be created - |
There was a problem hiding this comment.
Hi, thank you for your PR!
Code looks good to me. Would you have specific steps to reproduce the issue, just for me to check locally if it works?
pinging @marceloneppel too
|
Do you have access to Failing that, I can go through it in a Google Meet / screenshare session. Feel free to reach out to me on Mattermost. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all S3 implementations support LocationConstraint. This falls back to trying to create the bucket when
InvalidLocationConstraintencountered.#689