[MISC] Move uri generation to update endpoints #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #584 +/- ##
==========================================
+ Coverage 70.84% 70.89% +0.04%
==========================================
Files 12 12
Lines 3025 3030 +5
Branches 536 536
==========================================
+ Hits 2143 2148 +5
Misses 768 768
Partials 114 114 ☔ View full report in Codecov by Sentry. |
dragomirp
commented
Aug 14, 2024
Comment on lines
-118
to
-122
| # Set connection string URI. | ||
| self.database_provides.set_uris( | ||
| event.relation.id, | ||
| f"postgresql://{user}:{password}@{self.charm.primary_endpoint}:{DATABASE_PORT}/{database}", | ||
| ) |
There was a problem hiding this comment.
_on_database_requested is ran only when the db is requested, so the uri won't be updated if there's a switchover.
dragomirp
commented
Aug 14, 2024
| for relation_id in rel_data.keys(): | ||
| user = f"relation-{relation_id}" | ||
| database = rel_data[relation_id].get("database") | ||
| password = secret_data.get(relation_id, {}).get("password") |
There was a problem hiding this comment.
This will refetch all the secrets.
taurus-forever
approved these changes
Aug 16, 2024
marceloneppel
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move uri generation to
update_endpoints