[DPE-3562] Don't block on failure to get the db version #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #578 +/- ##
=======================================
Coverage 70.83% 70.84%
=======================================
Files 12 12
Lines 3024 3025 +1
Branches 535 536 +1
=======================================
+ Hits 2142 2143 +1
Misses 768 768
Partials 114 114 ☔ View full report in Codecov by Sentry. |
dragomirp
commented
Aug 9, 2024
Comment on lines
+394
to
+395
| if postgresql_version: | ||
| data["version"] = postgresql_version |
There was a problem hiding this comment.
Only add the version if we were able to get it.
dragomirp
commented
Aug 9, 2024
| @@ -319,14 +319,14 @@ def update_endpoints(self, relation: Relation = None) -> None: | |||
| if len(relations) == 0: | |||
| return | |||
|
|
|||
| postgresql_version = None | |||
| try: | |||
| postgresql_version = self.charm.postgresql.get_postgresql_version() | |||
There was a problem hiding this comment.
Alternatively we can use cluster.get_postgresql_version instead and get the version from the snap.
dragomirp
commented
Aug 9, 2024
Comment on lines
+434
to
+437
| if current_host: | ||
| host = self.current_host | ||
| else: | ||
| host = None |
There was a problem hiding this comment.
Use current_host by default, I think we still need to be able to call the primary for pgbouncer.
dragomirp
requested review from
marceloneppel,
taurus-forever and
lucasgameiroborges
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conditionally update the db version field in legacy relations if database is not accessible.
Related to #352 and #566