[DPE-5029] Wait for exact number of units after scale down

[marceloneppel]

Issue

The test_async_replication_failover_in_main_cluster test often fails with the following error:

File "/home/runner/actions-runner/_work/postgresql-operator/postgresql-operator/tests/integration/ha_tests/test_async_replication.py", line 489, in test_async_replication_failover_in_main_cluster
    assert new_sync_standby != sync_standby, "Sync-standby is the same as before"
AssertionError: Sync-standby is the same as before
assert 'postgresql-1' != 'postgresql-1'

Solution

Wait for the scale in operation to finish before checking whether the sync standby changed.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.96%. Comparing base (a870470) to head (d9607e6).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #565   +/-   ##
=======================================
  Coverage   70.96%   70.96%           
=======================================
  Files          11       11           
  Lines        3034     3034           
  Branches      538      538           
=======================================
  Hits         2153     2153           
  Misses        765      765           
  Partials      116      116           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[taurus-forever]

Nice catch!