Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISC] Show start/end time in UTC time in list-backups output #551

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

lucasgameiroborges
Copy link
Member

Issue

Output of command was converting timezones to local time, which can generate confusion + unit test was failing if local timezone not UTC.

Thanks to @dragomirp for raising this issue.

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.89%. Comparing base (2c0f64b) to head (fa0d96e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #551   +/-   ##
=======================================
  Coverage   70.89%   70.89%           
=======================================
  Files          11       11           
  Lines        3024     3024           
  Branches      535      535           
=======================================
  Hits         2144     2144           
  Misses        764      764           
  Partials      116      116           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lucasgameiroborges lucasgameiroborges changed the title [MISC] Show start/end time from list-backups output [MISC] Show start/end time in UTC time in list-backups output Jul 26, 2024
Copy link
Member

@marceloneppel marceloneppel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lucasgameiroborges lucasgameiroborges merged commit b9ebd8c into main Jul 30, 2024
79 checks passed
@lucasgameiroborges lucasgameiroborges deleted the lucas/fix-unit-test branch July 30, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants