Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DPE-4416] Update rolling-ops lib to version 0.7 #478

Merged
merged 10 commits into from
Jun 13, 2024
Merged

[DPE-4416] Update rolling-ops lib to version 0.7 #478

merged 10 commits into from
Jun 13, 2024

Conversation

lucasgameiroborges
Copy link
Member

@lucasgameiroborges lucasgameiroborges commented May 27, 2024 •
edited
Loading

Issue

charm-rolling-ops update to version LIBPATCH 7 causes unit tests to break (see #475).

Root cause: New lib version will trigger lock processing hook with every leader election event. This hook was failing in every test that triggers a leader election due to a missing relation on unit test setup.

Solution

Harness setup was missing required restart relation for RollingOpsManager.

Additional Changes

Two fixes for instabilities in test_async_replication integration test, specific description in PR comments.

marceloneppel
marceloneppel approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@marceloneppel marceloneppel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

tests/integration/ha_tests/test_async_replication.py Outdated Show resolved Hide resolved
src/relations/async_replication.py Outdated Show resolved Hide resolved
taurus-forever
taurus-forever approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@taurus-forever taurus-forever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to rolling-ops changes, but please agree with Mykola sync_stanby simplifications.

@dragomirp dragomirp mentioned this pull request Jun 5, 2024
Merged
@lucasgameiroborges lucasgameiroborges merged commit f135759 into main Jun 13, 2024
50 checks passed
@lucasgameiroborges lucasgameiroborges deleted the lucas/fix-unit-test branch June 13, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marceloneppel marceloneppel marceloneppel approved these changes

@dragomirp dragomirp dragomirp approved these changes

@taurus-forever taurus-forever taurus-forever approved these changes

@delgod delgod Awaiting requested review from delgod

Assignees
No one assigned
Labels
Libraries: Out of sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lucasgameiroborges @delgod @taurus-forever @dragomirp @marceloneppel