Handle test charm deps in a consistent way #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragomirp
commented
Feb 9, 2023
Comment on lines
+32
to
+36
| flake8 = "^6.0.0" | ||
| flake8-docstrings = "^1.7.0" | ||
| flake8-copyright = "^0.2.3" | ||
| flake8-copyright = "^0.2.4" | ||
| flake8-builtins = "^2.1.0" | ||
| pyproject-flake8 = "^5.0.4.post1" | ||
| pyproject-flake8 = "^6.0.0.post1" |
There was a problem hiding this comment.
flake8 6 seems to work now.
There was a problem hiding this comment.
Yeap, savoirfairelinux/flake8-copyright#19 is closed.
Can you please remove flake8 pinning from PSQL repos.
I have sent a MM notification to the team to clean pinning from their repos.
Nice!
taurus-forever
approved these changes
Feb 10, 2023
Comment on lines
+32
to
+36
| flake8 = "^6.0.0" | ||
| flake8-docstrings = "^1.7.0" | ||
| flake8-copyright = "^0.2.3" | ||
| flake8-copyright = "^0.2.4" | ||
| flake8-builtins = "^2.1.0" | ||
| pyproject-flake8 = "^5.0.4.post1" | ||
| pyproject-flake8 = "^6.0.0.post1" |
There was a problem hiding this comment.
Yeap, savoirfairelinux/flake8-copyright#19 is closed.
Can you please remove flake8 pinning from PSQL repos.
I have sent a MM notification to the team to clean pinning from their repos.
Nice!
marceloneppel
approved these changes
Feb 10, 2023
BON4
pushed a commit
to BON4/postgresql-k8s-operator
that referenced
this pull request
May 20, 2024
github-actions bot
added a commit
to canonical/test-runners-2-is-x64-postgresql-k8s-operator
that referenced
this pull request
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Solution
Context
Testing
Release Notes