[DPE-6052] Allow --restore-to-time=latest without a backup-id
#787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #787 +/- ##
==========================================
+ Coverage 75.46% 75.53% +0.07%
==========================================
Files 12 12
Lines 3118 3127 +9
Branches 476 478 +2
==========================================
+ Hits 2353 2362 +9
Misses 622 622
Partials 143 143 ☔ View full report in Codecov by Sentry. |
marceloneppel
changed the title
restore-to-time=latest--restore-to-time=latest without a backup-id
marceloneppel
requested review from
taurus-forever,
dragomirp and
lucasgameiroborges
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
taurus-forever
approved these changes
Nov 25, 2024
dragomirp
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When trying to restore to the latest time from a repository, the charm complains that a backup ID is required.
Solution
Allow users to restore without a backup ID (with only the
--restore-to-time=latestparameter).Also, add a new check that prevents the PITR and warns the user that there is no base backup in the latest timeline if there isn't one. Previously, if the user tried to restore from that timeline, the restore would be reported as successful, but in fact, it didn't happen.