Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache charmcraft pack container, skip unstable tests except on schedule #45

Merged
merged 6 commits into from
Feb 23, 2023
Merged

Cache charmcraft pack container, skip unstable tests except on schedule #45

merged 6 commits into from
Feb 23, 2023

Conversation

carlcsaposs-canonical
Copy link
Contributor

marceloneppel
marceloneppel reviewed Feb 19, 2023
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
taurus-forever
taurus-forever reviewed Feb 20, 2023
View reviewed changes
Copy link
Contributor

@taurus-forever taurus-forever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like tests need attention here. Unit test is failing on retrigger.

@carlcsaposs-canonical
Copy link
Contributor Author

It looks like tests need attention here. Unit test is failing on retrigger.

At first glance, the unit test failures appear unrelated to the changes in this PR

@dragomirp
Copy link
Contributor

It looks like tests need attention here. Unit test is failing on retrigger.

At first glance, the unit test failures appear unrelated to the changes in this PR

Tests from latest main don't fail both locally and in CI. I don't think anything was merged in the mean time. I'll take a look.

@carlcsaposs-canonical
Copy link
Contributor Author

It looks like tests need attention here. Unit test is failing on retrigger.

At first glance, the unit test failures appear unrelated to the changes in this PR

Tests from latest main don't fail both locally and in CI. I don't think anything was merged in the mean time. I'll take a look.

Perhaps it's related to removing {tox_root} from PYTHONPATH in tox.ini. If it's not that, I'm not sure what other changes might've caused it to fail

@carlcsaposs-canonical
Copy link
Contributor Author

Just tried adding {tox_root} back to PYTHONPATH and running unit tests locally; ran into the same issue

@carlcsaposs-canonical carlcsaposs-canonical merged commit 978a6d9 into main Feb 23, 2023
@carlcsaposs-canonical carlcsaposs-canonical deleted the feature/cache-charmcraft-pack branch February 23, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marceloneppel marceloneppel marceloneppel approved these changes

@dragomirp dragomirp dragomirp approved these changes

@taurus-forever taurus-forever Awaiting requested review from taurus-forever

Assignees
No one assigned
Labels
Libraries: Out of sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@carlcsaposs-canonical @dragomirp @taurus-forever @marceloneppel