Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: validate whole plan, rather than topmost two layers #363

Merged
merged 15 commits into from
Feb 23, 2024
Merged

fix: validate whole plan, rather than topmost two layers #363

merged 15 commits into from
Feb 23, 2024

Commits on Feb 19, 2024

  1. Move validation into a dedicated method.

    @tonyandrewmeyer
    tonyandrewmeyer committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    3c49298 View commit details
    Browse the repository at this point in the history

  2. Split validation into layer and plan.

    @tonyandrewmeyer
    tonyandrewmeyer committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    838c0ba View commit details
    Browse the repository at this point in the history

  3. Remove invalid layer cycle check.

    @tonyandrewmeyer
    tonyandrewmeyer committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    049b23e View commit details
    Browse the repository at this point in the history

  4. Adjust/add tests to validate behaviour.

    @tonyandrewmeyer
    tonyandrewmeyer committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    a838310 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2024

  1. Add tests for this specific case.

    @tonyandrewmeyer
    tonyandrewmeyer committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    971740a View commit details
    Browse the repository at this point in the history

  2. Remove accidental debug bin commit.

    @tonyandrewmeyer
    tonyandrewmeyer committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    41ddb8a View commit details
    Browse the repository at this point in the history

  3. Ignore __debug_bin* files.

    @tonyandrewmeyer
    tonyandrewmeyer committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    65a781a View commit details
    Browse the repository at this point in the history

  4. Update internals/plan/plan.go 

    Co-authored-by: Ben Hoyt <[email protected]>
    @tonyandrewmeyer @benhoyt
    tonyandrewmeyer and benhoyt authored Feb 20, 2024
    Configuration menu
    Copy the full SHA
    df0cc88 View commit details
    Browse the repository at this point in the history

  5. Remove delve-specific ignore file.

    @tonyandrewmeyer
    tonyandrewmeyer committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    270e7de View commit details
    Browse the repository at this point in the history

  6. Use clearer name for the layer object.

    @tonyandrewmeyer
    tonyandrewmeyer committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    ba58cce View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. Typo, as per code review.

    @tonyandrewmeyer
    tonyandrewmeyer committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    55ac675 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2024

  1. Adjustments as per review.

    @tonyandrewmeyer
    tonyandrewmeyer committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    083a892 View commit details
    Browse the repository at this point in the history

  2. Small fix and add tests for the period/timeout cases.

    @tonyandrewmeyer
    tonyandrewmeyer committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    0bf1186 View commit details
    Browse the repository at this point in the history

  3. Fix test the correct way.

    @tonyandrewmeyer
    tonyandrewmeyer committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    af63dc7 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2024

  1. Remove the mutation from the validation func.

    @tonyandrewmeyer
    tonyandrewmeyer committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    71dc45a View commit details
    Browse the repository at this point in the history