Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(daemon): Export error responders from daemon.response #360

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

thp-canonical
Copy link
Contributor

@thp-canonical thp-canonical commented Feb 14, 2024

This brings the error response namings in line with snapd: daemon/errors.go in snapd. Split off from #358. While currently the error responses are used exclusively in the daemon package, once AccessChecker is available, it should be possible for other packages to create error responders to implement their AccessChecker variants.

Copy link
Contributor

@benhoyt benhoyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this looks good -- brings it in line with snapd's names and exported status, and will make it possible to import and use these errors in external projects.

@benhoyt benhoyt merged commit 921602d into canonical:master Feb 19, 2024
15 checks passed
@thp-canonical thp-canonical deleted the response-types branch February 19, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants