fix(state): don't lock global state lock when adding a task log #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes the service manager has to write a task log, but there's a 3-way deadlock where another goroutine has held the state lock. Break this cycle.
|
Closing in favour of #359, which is much less invasive, and it seems a better approach to structure the locking better rather than do surgery to the state package. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the service manager has to write a task log, but there's a
3-way deadlock where another goroutine has held the state lock. Break
this cycle.
See #314 -- either this PR or #355 by itself will fix that issue.
I'm not sure about this PR. I like what it's trying to achieve, but it also
begs the question: why do we have this one special fine-grained lock
for the task log, and not for all the other fields?