Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(daemon): handle invalid notice types in filter #329

Merged
merged 3 commits into from
Nov 20, 2023
Merged

fix(daemon): handle invalid notice types in filter #329

merged 3 commits into from
Nov 20, 2023

Commits on Nov 16, 2023

  1. daemon: fix handling of invalid notice types in filter 

    Invalid notice types are ignored when parsing the API request to
construct the notice filter. However, if only invalid notice types are
included in the request, discarding all types results in a filter
indistinguishable from one which never had any types in the first place,
and thus should return notices of any type. This commit fixes this
behaviour, so no notices are returned if only invalid notice types are
requested.

Signed-off-by: Oliver Calder <[email protected]>
    @olivercalder
    olivercalder committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    c40bd32 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2023

  1. Merge branch 'master' into handle-invalid-types

    @benhoyt
    benhoyt committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    5c66c38 View commit details
    Browse the repository at this point in the history

  2. daemon: notices tweaks following review 

    Signed-off-by: Oliver Calder <[email protected]>
    @benhoyt @olivercalder
    benhoyt authored and olivercalder committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    cd79052 View commit details
    Browse the repository at this point in the history