fix: allow local building and testing of the snap on PRs #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjdcordeiro
force-pushed
the
test-snap-on-prs
branch
6 times, most recently
from
ba0010f
to
042fe29
Compare
benhoyt
reviewed
Nov 11, 2023
cjdcordeiro
force-pushed
the
test-snap-on-prs
branch
8 times, most recently
from
45ba848
to
9749b41
Compare
cjdcordeiro
force-pushed
the
test-snap-on-prs
branch
from
9749b41
to
0bf5d7b
Compare
|
Looks good to me. Merged without further review -- this is CI only so easy to tweak later if necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The snap workflows can't currently run for PRs created from forks, since the repo's policy is not to allow forks to access any secrets.
The caveat here is that, for PRs, we won't be able to assert if the snap can build for architectures other than the GH's
runner.arch. I don't think there's a way around this since the multi-arch build relies on LP, and for that we always need credentials.To be fair, the same would happen if we still had the Snap store connected to this repo, since the multi-arch builds would also only happen on
pushtomaster.In this PR
The snap.yaml workflow builds the snap with basis on the type of event triggering the workflow:
amd64, and usesnapcraft packpushandrelease), the snap build will rely on LP (i.e.snapcraft remote-build)