Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Pebble internals into an exportable package #226

Merged
merged 4 commits into from
May 29, 2023
Merged

Refactor Pebble internals into an exportable package #226

merged 4 commits into from
May 29, 2023

Commits on May 23, 2023

  1. Rename internal to internals 

    The `internal` package name is special in Go: it makes the package
non-importable.  We rename it to `internals` so that we can import it
from other software while conveying the idea of it being of internal
use.
    @anpep
    anpep committed May 23, 2023
    Configuration menu
    Copy the full SHA
    56373c6 View commit details
    Browse the repository at this point in the history

  2. Refactor main package into internals/cli. 

    The `main` package is special in Go: it is reserved for the package
containing a `main()` function that serves as the entry point for the
program and it can't be imported.

This commit refactors all command-line functionality that will be
shared by other software into the `internals/cli` package, which will be
imported and used by the `main()` function to invoke the Pebble
command-line interface.
    @anpep
    anpep committed May 23, 2023
    Configuration menu
    Copy the full SHA
    01813d0 View commit details
    Browse the repository at this point in the history

  3. Fix CI tests for new internals package.

    @anpep
    anpep committed May 23, 2023
    Configuration menu
    Copy the full SHA
    f981ef4 View commit details
    Browse the repository at this point in the history

  4. Minor fixes.

    @anpep
    anpep authored May 23, 2023
    Configuration menu
    Copy the full SHA
    1fdf9cb View commit details
    Browse the repository at this point in the history