Pass service description's environment variables to child process #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niemeyer
requested changes
Mar 22, 2021
| cmd.Env = os.Environ() | ||
| for _, v := range service.Environment { | ||
| cmd.Env = append(cmd.Env, v.Name+"="+v.Value) | ||
| } |
There was a problem hiding this comment.
Thanks for fixing this, Ben. We indeed need a good test for this sort of change.
There was a problem hiding this comment.
Ah, and it's also worth checking (and testing) what happens if there's a variable in the environment process which needs to be replaced by something explicit on the service.
There was a problem hiding this comment.
Added a test for this: it tests brand new env vars, env vars only set in the parent, and env vars in the parent but overridden in the layer config. I'll do any $PATH type of interpolation in a subsequent commit.
niemeyer
approved these changes
Mar 23, 2021
| command: /bin/sh -c "env | grep PEBBLE_ENV_TEST | sort > %s; sleep 300" | ||
| environment: | ||
| - PEBBLE_ENV_TEST_1: foo | ||
| - PEBBLE_ENV_TEST_2: bar bazz |
jujubot
added a commit
to juju/juju
that referenced
this pull request
Mar 23, 2021
#12804 This includes the following Pebble fixes: * canonical/pebble#18 - Pass service description's environment variables to child process * canonical/pebble#20 - Change default: start/stop to startup: enabled/disabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty self-explanatory. Fixes #17