Add boot-firmware command #176
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Implement boot-firmware command * Run boot-firmware by default on Termus when no arguments are provided to Pebble and basic bootstrap checks pass.
benhoyt
reviewed
Jan 9, 2023
flotter
reviewed
Jan 19, 2023
* The `boot` package has been renamed to `bootstrap` * Build variant boilerplate has been removed from the `bootstrap` package, and it's been substituted by a variant-specific implementation of the `boot-firmware` command.
flotter
reviewed
Mar 6, 2023
|
Per our agreements, closing as this is moving elsewhere now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
boot-firmwarecommand (spec), which does some initialization prior to starting the Pebble daemon on Termus.Feedback is greatly appreciated, especially on the usage of build tags and how unit tests are structured.
This PR is kind of blocked on #201. After #201 is merged, I will remove the ad-hoc wrappers of the mount/umount syscalls here and use
osutil.Mount()andosutil.Unmount().