pr fix: remove DELETE from Command

canonical · Feb 14, 2024 · 89f05b6 · 89f05b6
1 parent 42cbc15
commit 89f05b6
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 7 deletions.
diff --git a/internals/daemon/api_test.go b/internals/daemon/api_test.go
@@ -80,7 +80,6 @@ func (s *apiSuite) TestSysInfo(c *check.C) {
 	c.Assert(sysInfoCmd.GET, check.NotNil)
 	c.Check(sysInfoCmd.PUT, check.IsNil)
 	c.Check(sysInfoCmd.POST, check.IsNil)
-	c.Check(sysInfoCmd.DELETE, check.IsNil)
 
 	rec := httptest.NewRecorder()
 

diff --git a/internals/daemon/daemon.go b/internals/daemon/daemon.go
@@ -126,7 +126,6 @@ type Command struct {
 	GET    ResponseFunc
 	PUT    ResponseFunc
 	POST   ResponseFunc
-	DELETE ResponseFunc
 
 	// Access control.
 	ReadAccess  accessChecker
@@ -185,9 +184,6 @@ func (c *Command) ServeHTTP(w http.ResponseWriter, r *http.Request) {
 	case "POST":
 		rspf = c.POST
 		access = c.WriteAccess
-	case "DELETE":
-		rspf = c.DELETE
-		access = c.WriteAccess
 	}
 
 	if rspf == nil {

diff --git a/internals/daemon/daemon_test.go b/internals/daemon/daemon_test.go
@@ -222,9 +222,8 @@ func (s *daemonSuite) TestCommandMethodDispatch(c *C) {
 	cmd.GET = rf
 	cmd.PUT = rf
 	cmd.POST = rf
-	cmd.DELETE = rf
 
-	for _, method := range []string{"GET", "POST", "PUT", "DELETE"} {
+	for _, method := range []string{"GET", "POST", "PUT"} {
 		req, err := http.NewRequest(method, "", nil)
 		req.Header.Add("User-Agent", fakeUserAgent)
 		c.Assert(err, IsNil)