Fix: EOL filtering to only exclude builds with no valid tracks. #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clay-lake
force-pushed
the
fix_eol_filtering
branch
from
f5af210
to
ae87140
Compare
cjdcordeiro
reviewed
Oct 21, 2024
| from src.shared.github_output import GithubOutput | ||
| from src.image.utils.schema.triggers import ImageSchema | ||
|
|
||
| # TODO: |
There was a problem hiding this comment.
Good point. I think it does. We might need some sort of validator to check the source and transform it to a GH URL when appropriate only.
It's what you already do in the custom checkout action. So the question is whether we can transform this data in a single place, early in the pipeline, instead of duplicating the logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Included in this PR:
2.9.2globally.