Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: add pytest job to _Test-OCI-Factory workflow #224

Merged
merged 16 commits into from
Aug 30, 2024
Merged

Feat: add pytest job to _Test-OCI-Factory workflow #224

merged 16 commits into from
Aug 30, 2024

Conversation

clay-lake
Copy link
Contributor

Ping the @canonical/rocks team.

This PR adds a job to .github/workflows/_Test-OCI-Factory.yaml which executes pytest from the root of the repository and generates a simple test report to that step's $GITHUB_STEP_SUMMARY.

More tests will be added in subsequent refactoring PRs

@clay-lake
Copy link
Contributor Author

Here is a sample integration where you can see the test summary, and the uploaded jUnit report artifact.
https://github.com/clay-lake/oci-factory/actions/runs/10473012228

cjdcordeiro
cjdcordeiro requested changes Aug 21, 2024
View reviewed changes
Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds like a good initiative.

I'd like to see this combined with at least one test, so I'd wait at least until 1 test is ready.

.github/workflows/_Test-OCI-Factory.yaml Outdated Show resolved Hide resolved
.github/workflows/_Test-OCI-Factory.yaml Outdated Show resolved Hide resolved
.github/workflows/_Test-OCI-Factory.yaml Outdated Show resolved Hide resolved
.github/workflows/_Test-OCI-Factory.yaml Outdated Show resolved Hide resolved
src/test-oci-factory/pytest/format_markdown_report.py Outdated Show resolved Hide resolved
zhijie-yang
zhijie-yang requested changes Aug 22, 2024
View reviewed changes
.github/workflows/_Test-OCI-Factory.yaml Outdated Show resolved Hide resolved
.github/workflows/_Test-OCI-Factory.yaml Outdated Show resolved Hide resolved
@clay-lake clay-lake mentioned this pull request Aug 23, 2024
Merged
2 tasks
linostar
linostar approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@linostar linostar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks neat and good. My remarks have already been addressed.

cjdcordeiro
cjdcordeiro requested changes Aug 23, 2024
View reviewed changes
Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost there. You may also want to lint all files. Some are missing a newline at EOF and others have inconsistent break lines throughout the text

.github/workflows/_Test-OCI-Factory.yaml Show resolved Hide resolved
zhijie-yang
zhijie-yang approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@zhijie-yang zhijie-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now. Thanks!

cjdcordeiro
cjdcordeiro approved these changes Aug 30, 2024
View reviewed changes
Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

greeeat thanks

@cjdcordeiro cjdcordeiro self-assigned this Aug 30, 2024
@cjdcordeiro cjdcordeiro merged commit e780734 into canonical:main Aug 30, 2024
4 checks passed
@clay-lake clay-lake deleted the feat_add_pytest_job branch August 30, 2024 12:29
zhijie-yang pushed a commit that referenced this pull request Sep 10, 2024
@clay-lake @zhijie-yang
Feat: add pytest job to _Test-OCI-Factory workflow (#224)
1914069
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhijie-yang zhijie-yang zhijie-yang approved these changes

@cjdcordeiro cjdcordeiro cjdcordeiro approved these changes

@linostar linostar linostar approved these changes

Assignees

@cjdcordeiro cjdcordeiro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@clay-lake @linostar @cjdcordeiro @zhijie-yang