Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport: Add alert rules to jupyter-controller based on the KF093 spec (#402) #410

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Backport: Add alert rules to jupyter-controller based on the KF093 spec (#402) #410

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions charms/jupyter-controller/src/prometheus_alert_rules/KubeflowJupyterControllerServices.rules
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
groups:
- name: KubeflowJupyterControllerServices
rules:
- alert: KubeflowServiceDown
expr: up{} < 1
for: 5m
labels:
severity: critical
annotations:
summary: "{{ $labels.juju_charm }} service is Down ({{ $labels.juju_model }}/{{ $labels.juju_unit }})"
description: |
One or more targets of {{ $labels.juju_charm }} charm are down on unit {{ $labels.juju_model }}/{{ $labels.juju_unit }}.
LABELS = {{ $labels }}

- alert: KubeflowServiceIsNotStable
expr: avg_over_time(up{}[10m]) < 0.5
for: 0m
labels:
severity: warning
annotations:
summary: "{{ $labels.juju_charm }} service is not stable ({{ $labels.juju_model }}/{{ $labels.juju_unit }})"
description: |
{{ $labels.juju_charm }} unit {{ $labels.juju_model }}/{{ $labels.juju_unit }} has been unreachable at least 50% of the time over the last 10 minutes.
LABELS = {{ $labels }}
10 changes: 0 additions & 10 deletions charms/jupyter-controller/src/prometheus_alert_rules/unit_unavailable.rule
View file
Open in desktop

This file was deleted.

6 changes: 4 additions & 2 deletions charms/jupyter-controller/tests/unit/test_operator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,9 +115,11 @@ def test_prometheus_data_set(self, harness: Harness, mocker):
with open("src/prometheus_alert_rules/model_errors.rule") as f:
file_alert = yaml.safe_load(f.read())
test_alerts.append(file_alert["alert"])
with open("src/prometheus_alert_rules/unit_unavailable.rule") as f:
with open("src/prometheus_alert_rules/KubeflowJupyterControllerServices.rules") as f:
file_alert = yaml.safe_load(f.read())
test_alerts.append(file_alert["alert"])
# there 2 alert rules in host_resources.rules
for rule in file_alert["groups"][0]["rules"]:
test_alerts.append(rule["alert"])

# alert rules
alert_rules = json.loads(
Expand Down
Loading