Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contributing files #310

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Contributing files #310

merged 2 commits into from
Oct 4, 2023

Conversation

ColmBhandal
Copy link
Contributor

Added contributing files for the controller and UI charms.

@ColmBhandal ColmBhandal requested a review from a team as a code owner October 3, 2023 08:23
i-chvets
i-chvets previously approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@i-chvets i-chvets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@i-chvets i-chvets dismissed their stale review October 4, 2023 13:55

See comments.

@i-chvets
Copy link
Contributor

i-chvets commented Oct 4, 2023

@ColmBhandal Are file names should be capitalized? I.e. CONTRIBUTING.md?

@ColmBhandal
Copy link
Contributor Author

@orfeas-k I replied to your suggestions.

@ColmBhandal ColmBhandal merged commit 36dd122 into main Oct 4, 2023
14 checks passed
@ColmBhandal ColmBhandal deleted the KF-4514-Jupyter-Contributing-Files branch October 4, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orfeas-k orfeas-k orfeas-k approved these changes

@i-chvets i-chvets i-chvets left review comments

Assignees
No one assigned
Labels
Libraries: OK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ColmBhandal @i-chvets @orfeas-k