Skip to content

Commit

Permalink
fix: Pin Prometheus revision to 137
Browse files Browse the repository at this point in the history
Pin Prometheus revision when deploying from `latest` to avoid fetching
recent patches of the charm which assume `juju >= 3.0.3`.
This is temporary patch until we migrate to Juju 3.1.

Signed-off-by: Phoevos Kalemkeris <[email protected]>
  • Loading branch information
phoevos committed Sep 1, 2023
1 parent 1649903 commit 0333b2e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion charms/jupyter-controller/tests/integration/test_charm.py
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ async def test_prometheus_integration(ops_test: OpsTest):
scrape_config = {"scrape_interval": "30s"}

# Deploy and relate prometheus
await ops_test.model.deploy(prometheus, channel="latest/stable", trust=True)
await ops_test.model.deploy(prometheus, channel="latest/stable", revision=137, trust=True)
await ops_test.model.deploy(prometheus_scrape, channel="latest/stable", config=scrape_config)

await ops_test.model.add_relation(APP_NAME, prometheus_scrape)
Expand Down
2 changes: 1 addition & 1 deletion tests/test_charms.py
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ async def test_prometheus_grafana_integration(ops_test):
scrape_config = {"scrape_interval": "30s"}

# Deploy and relate prometheus
await ops_test.model.deploy(prometheus, channel="latest/edge", trust=True)
await ops_test.model.deploy(prometheus, channel="latest/edge", revision=137, trust=True)
await ops_test.model.deploy(grafana, channel="latest/edge", trust=True)
await ops_test.model.deploy(prometheus_scrape, channel="latest/beta", config=scrape_config)

Expand Down

0 comments on commit 0333b2e

Please sign in to comment.