Standardize abstract_charm.py file with the K8s charm #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shayancanonical
requested review from
paulomach,
taurus-forever and
carlcsaposs-canonical
There was a problem hiding this comment.
please wait for canonical/mysql-router-k8s-operator#328 merge before merging this pr
I am pending decision in K8s before reviewing VM one. |
@paulomach K8s got merged yesterday. Should this follow? |
@taurus-forever no. It's currently out of sync. I rather wait for @shayancanonical to resync it. |
shayancanonical
requested review from
carlcsaposs-canonical and
sinclert-canonical
sinclert-canonical
approved these changes
Dec 9, 2024
shayancanonical
added a commit
to canonical/mysql-router-k8s-operator
that referenced
this pull request
Dec 9, 2024
…arm (#339) ## Issue While standardizing code in the router vm charm (canonical/mysql-router-operator#182), there were small minor adjustments that needed to be made in the code in this repo ## Solution Propagate appropriate changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The
abstract_charm.pyhas diverged with the K8s charm following in support of HACluster charm integration +expose-externalconfig in the K8s charm.Solution
Standardize the files
Counterpart PR in K8s charm: canonical/mysql-router-k8s-operator#328