Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set BlockedStatus if unsupported extra user role requested #66

Merged
merged 3 commits into from
May 22, 2023
Merged

Set BlockedStatus if unsupported extra user role requested #66

merged 3 commits into from
May 22, 2023

Conversation

carlcsaposs-canonical
Copy link
Contributor

Issue

Fixes #61

benhoyt
benhoyt reviewed May 22, 2023
View reviewed changes
Copy link

@benhoyt benhoyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This refactor definitely seems clear and easy to follow. It would be nice to have unit tests of this status-setting logic.

@carlcsaposs-canonical
Copy link
Contributor Author

carlcsaposs-canonical commented May 22, 2023 •
edited by jira bot
Loading

This refactor definitely seems clear and easy to follow. It would be nice to have unit tests of this status-setting logic.

There's an open ticket here: DPE-1687

@carlcsaposs-canonical carlcsaposs-canonical mentioned this pull request May 22, 2023
Closed
paulomach
paulomach approved these changes May 22, 2023
View reviewed changes
Copy link
Collaborator

@paulomach paulomach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@carlcsaposs-canonical carlcsaposs-canonical merged commit 7e86133 into main May 22, 2023
@carlcsaposs-canonical carlcsaposs-canonical deleted the extra-user-role-status branch May 22, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benhoyt benhoyt benhoyt left review comments

@paulomach paulomach paulomach approved these changes

@delgod delgod delgod approved these changes

@shayancanonical shayancanonical Awaiting requested review from shayancanonical

@taurus-forever taurus-forever Awaiting requested review from taurus-forever

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set BlockedStatus if unsupported extra user role requested
4 participants
@carlcsaposs-canonical @delgod @paulomach @benhoyt