Update charmed-mysql rock image to latest edge version #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shayancanonical
requested review from
paulomach,
taurus-forever and
carlcsaposs-canonical
taurus-forever
approved these changes
Apr 30, 2024
|
@shayancanonical please add to the PR description the new ROCK content (for the history and release notes). Tnx! |
Comment on lines
+484
to
+485
|
|
||
| PYDEPS = ["cosl"] |
There was a problem hiding this comment.
can this be added to pyproject.toml?
There was a problem hiding this comment.
i believe that there is already an entry for cosl = "*" in pyproject.toml. corrected the comment for the source in db8aa3f and also remove extraneous pydantic
carlcsaposs-canonical
approved these changes
May 1, 2024
shayancanonical
added a commit
that referenced
this pull request
May 2, 2024
## Issue As part of [PR 237](#237), the `lib-check` CI step was moved to run during pull request from release. However, the release still `needs` `lib-check` which no longer exists ## Solution Remove the `lib-check` pre-req for release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes innocuous changes to router: from canonical/charmed-mysql-snap#47